Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return the previous behavior of the data length GTF #479

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Return the previous behavior of the data length GTF #479

merged 2 commits into from
Jun 8, 2023

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Jun 8, 2023 •
edited
Loading

After #373 the GTF for data length is not working for MessageCoinSigned and MessageCoinPredicate

@xgreenx xgreenx self-assigned this Jun 8, 2023
@xgreenx xgreenx requested a review from a team June 8, 2023 20:39
Dentosal
Dentosal approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@Dentosal Dentosal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xgreenx xgreenx merged commit b7b3e29 into release/0.31.2 Jun 8, 2023
@xgreenx xgreenx deleted the feature/data-length-fix branch June 8, 2023 23:07
@xgreenx xgreenx mentioned this pull request Jun 9, 2023
Merged
@Voxelot
Copy link
Member

Voxelot commented Jun 9, 2023

As a todo, we should ensure there is at least happy-path test coverage for each of these GTF flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dentosal Dentosal Dentosal approved these changes

Assignees

@xgreenx xgreenx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xgreenx @Voxelot @Dentosal