Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more memory range test cases #380

Merged
merged 11 commits into from
Mar 17, 2023
Merged

Conversation

Dentosal
Copy link
Member

Some of the cases around logd were not documented, see this spec PR: FuelLabs/fuel-specs#468

@Dentosal Dentosal requested a review from a team March 13, 2023 18:03
@Dentosal Dentosal self-assigned this Mar 13, 2023
Copy link
Contributor

@ControlCplusControlV ControlCplusControlV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just some minor nits

fuel-vm/tests/log.rs Outdated Show resolved Hide resolved
fuel-vm/tests/spec.rs Outdated Show resolved Hide resolved
fuel-vm/tests/spec.rs Outdated Show resolved Hide resolved
@ControlCplusControlV ControlCplusControlV requested a review from a team March 16, 2023 15:31
freesig
freesig previously approved these changes Mar 17, 2023
Copy link
Contributor

@freesig freesig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work

@Dentosal
Copy link
Member Author

I've removed the jump tests here, those are covered in the relative jumps PR: #381

@Dentosal Dentosal added this pull request to the merge queue Mar 17, 2023
@Dentosal Dentosal merged commit 5d6dd1d into master Mar 17, 2023
@Dentosal Dentosal deleted the dento/memory-range-tests-1 branch March 17, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants