Make prepare_call unit testable #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-vm into freesig/avoid-code-clone-2
…-vm into freesig/unit-test-call
Dentosal
reviewed
Feb 16, 2023
Voxelot
reviewed
Feb 23, 2023
Voxelot
reviewed
Feb 24, 2023
xgreenx
reviewed
Feb 24, 2023
Voxelot
reviewed
Feb 24, 2023
Voxelot
reviewed
Feb 24, 2023
Voxelot
reviewed
Feb 24, 2023
Voxelot
reviewed
Feb 24, 2023
Voxelot
reviewed
Feb 24, 2023
Voxelot
reviewed
Feb 24, 2023
Voxelot
reviewed
Feb 24, 2023
Voxelot
reviewed
Feb 24, 2023
Voxelot
reviewed
Feb 24, 2023
freesig
commented
Feb 27, 2023
| @@ -44,7 +44,7 @@ serde_json = "1.0" | |||
| test-case = "2.2" | |||
|
|
|||
| [features] | |||
| default = ["optimized"] | |||
| default = [] | |||
There was a problem hiding this comment.
Just flagging this as it's a significant change
Voxelot
reviewed
Feb 27, 2023
Voxelot
reviewed
Feb 27, 2023
xgreenx
reviewed
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces lots of utilities (especially around multiple mutable borrows of arrays, registers and memory) so that the scope of what is passed into a function is only related to that function and then can be unit tested.
Refs #350