Limit the number of receipts to u16::MAX #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentosal
added
documentation
xgreenx
reviewed
Nov 9, 2023
src/identifiers/utxo-id.md
Outdated
| @@ -18,7 +18,7 @@ The ID of a message is computed as the [hash](../protocol/cryptographic-primitiv | |||
|
|
|||
| ### Message Nonce | |||
|
|
|||
| The nonce value for `InputMessage` is determined by the sending system and is published at the time the message is sent. The nonce value for `OutputMessage` is computed as the [hash](../protocol/cryptographic-primitives.md#hashing) of the [Transaction ID](./transaction-id.md) that emitted the message and the index of the message receipt `uint8`: `hash(byte[32] ++ uint8)`. | |||
| The nonce value for `InputMessage` is determined by the sending system and is published at the time the message is sent. The nonce value for `OutputMessage` is computed as the [hash](../protocol/cryptographic-primitives.md#hashing) of the [Transaction ID](./transaction-id.md) that emitted the message and the index of the message receipt `uint16`: `hash(byte[32] ++ uint16)`. | |||
There was a problem hiding this comment.
Do we want to highlight the uint16 uses canonical serialization?
There was a problem hiding this comment.
Likely. The canonical serialization is just a u64, so it makes sense to highlight this.
There was a problem hiding this comment.
I added that in 5a2dfe6
xgreenx
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases the receipt limit from
u8::MAXtou16::MAX, leaving space for panic and script result. The old limit was not enforced, but FuelLabs/fuel-vm#633 is going to enforce the new rules defined here.The number of receipts is limited separtely from gas, since adding more receipts slows down all instructions that operate on them. Moreover, this change makes the upper bound for memory use clear.