Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove halt opcode #48

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Remove halt opcode #48

merged 1 commit into from
Feb 9, 2021

Conversation

adlerjohn
Copy link
Contributor

@adlerjohn adlerjohn commented Feb 9, 2021

Remove the HALT opcode. Allowing any contract to persist state changes is dangerous. If the contract enters an unrecoverable state, then the entire transaction can be reverted. If the contract can recover, then it should return to the caller with an error code.

@adlerjohn adlerjohn added the bug Something isn't working label Feb 9, 2021
@adlerjohn adlerjohn self-assigned this Feb 9, 2021
@adlerjohn adlerjohn merged commit 34c4888 into master Feb 9, 2021
@adlerjohn adlerjohn deleted the adlerjohn-remove_halt branch February 9, 2021 20:23
@adlerjohn adlerjohn added the comp:FVM Component: FuelVM label Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working comp:FVM Component: FuelVM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant