-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add SMT test spec and test fixtures #389
Conversation
would it be more accurate to call these |
Yea, I agree, I think that's a good distinction. I've updated the folder name to |
Git submodules can be a little tricky to manage sometimes.. Is there a way we could use git hooks to automatically pull these test-vectors into fuel-merkle? |
I agree that submodules can be tricky: codebases that uses submodules have to remember to run all the submodule commands, i.e. I can look into alternative solutions, like git hooks. If we can automate pulling in the test vectors, that would be great. That said, can we get the test vectors into |
Verification is easier than execution after all, so my preference would instead be a CI workflow in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Related issues:
fuel-specs
repo fuel-merkle#80This PR adds the SMT test specification and related test fixtures currently living in the
fuel-merkle
repo to thefuel-specs
repo. Thefuel-specs
repo is the appropriate housing for these documents since they describe universally applicable test outputs and are agnostic to any implementation. Sparse Merkle tree implementations can adhere to the SMT test specifications infuel-specs
to ensure correctness; this includes thefuel-merkle
crate andfuel-merkle-sol
library.SMT libraries can include the
fuel-specs
repo as a git submodule in order to pull in the test fixtures.In a future PR, I will remove the existing test spec and fixture files from
fuel-merkle
and specifyfuel-specs
as a submodule.