Add BAL balance opcode #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
adlerjohn
reviewed
Nov 23, 2021
vlopes11
reviewed
Nov 24, 2021
adlerjohn
previously approved these changes
Nov 24, 2021
|
Should also probably update with the new details about panic reasons added to the rest of the opcodes in #227. |
adlerjohn
reviewed
Nov 25, 2021
|
Does the color need to be in |
No, because it's getting the balance of a colored coin for a contract, of any color. |
adlerjohn
approved these changes
Nov 26, 2021
vlopes11
added a commit
to FuelLabs/fuel-asm
that referenced
this pull request
Nov 30, 2021
vlopes11
added a commit
to FuelLabs/fuel-asm
that referenced
this pull request
Dec 1, 2021
vlopes11
added a commit
to FuelLabs/fuel-vm
that referenced
this pull request
Dec 4, 2021
The opcode implementation brings the ability to inspect the balance of a given color+contract tuple. This allows the test case `mint_burn` to be moved to the integrated scope since before this opcode, there was no way to fetch the balance of the tuple without inspecting the internals of the interpreter. Follows FuelLabs/fuel-specs#226
vlopes11
added a commit
to FuelLabs/fuel-vm
that referenced
this pull request
Dec 4, 2021
The opcode implementation brings the ability to inspect the balance of a given color+contract tuple. This allows the test case `mint_burn` to be moved to the integrated scope since before this opcode, there was no way to fetch the balance of the tuple without inspecting the internals of the interpreter. Follows FuelLabs/fuel-specs#226
ControlCplusControlV
pushed a commit
to FuelLabs/fuel-vm
that referenced
this pull request
Dec 1, 2022
xgreenx
pushed a commit
to FuelLabs/fuel-vm
that referenced
this pull request
Dec 20, 2022
xgreenx
pushed a commit
to FuelLabs/fuel-vm
that referenced
this pull request
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #225.
TRandTROopcodes. But this seems to make more sense if we want to add aSELFBALopcode in the future for getting the balance of the current contract ID, where we would just drop the contract ID argument.