This repository has been archived by the owner on Oct 25, 2024. It is now read-only.
fix: update MessageOut data parsing due to API change #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to a change in how the
datafield in aMessageOutreceipt is formed, our type ID and data parsing did not cover each case. This PR adjusts the parsing to check for aNonevalue as well as an empty byte array as well.Testing steps
On
develop: Clear database, build any indexer (fuel-exploreris probably best) and run indexer on internal beta-4 test network. You should see a failure at or near block 364788.On this branch: Repeat above steps. You should see no failure.