fault_proving(global_roots): Populate Blobs table
#2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netrome
force-pushed
the
2586-fault_provingglobal_roots-populate-blobs-table
branch
from
2bc87dd to
5db1b99
Compare
netrome
requested review from
xgreenx,
Dentosal,
MitchTurner,
acerone85,
rafal-ch,
rymnc and
AurelienFT
as code owners
acerone85
reviewed
Feb 4, 2025
rymnc
reviewed
Feb 5, 2025
|
|
||
| // Given | ||
| let blob = vec![1, 3, 3, 7]; | ||
| let blob_id = BlobId::compute(&blob); |
There was a problem hiding this comment.
what happens when we already have a blob that already exists? should we throw an error or just overwrite it?
There was a problem hiding this comment.
I don't know the current behavior of the node (whether we allow duplicate blobs or not), but here we should only receive valid transactions. Since blobs are content-addressed it doesn't really matter. We could probably just ignore it, since we already have the blob stored. The behavior should only matter if we have hash collisions, which in practice doesn't happen afaik.
rymnc
previously approved these changes
Feb 5, 2025
acerone85
previously approved these changes
Feb 5, 2025
netrome
force-pushed
the
2586-fault_provingglobal_roots-populate-blobs-table
branch
from
f7b2d7a to
b4ea7fa
Compare
acerone85
approved these changes
Feb 5, 2025
rymnc
approved these changes
Feb 5, 2025
netrome
deleted the
2586-fault_provingglobal_roots-populate-blobs-table
branch
Merged
AurelienFT
added a commit
that referenced
this pull request
Feb 5, 2025
## Version 0.41.6 ### Added - [2668](#2668): Expose gas price service test helpers - [2621](#2598): Global merkle root storage updates process upgrade transactions. - [2650](#2650): Populate `ProcessedTransactions` table in global merkle root storage. - [2667](#2667): Populate `Blobs` table in global merkle root storage. - [2652](#2652): Global Merkle Root storage crate: Add Raw contract bytecode to global merkle root storage when processing Create transactions. ### Fixed - [2673](#2673): Change read behavior on the InMemoryTransaction to use offset and allow not equal buf size (fix CCP and LDC broken from FuelLabs/fuel-vm#847)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2586