Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make snapshot command members pub accessible #1906

Merged
merged 3 commits into from
May 27, 2024
Merged

chore: Make snapshot command members pub accessible #1906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
072a123
Make snapshot command members pub accessible
bvrooman May 25, 2024
1ed2adf
Update CHANGELOG.md
bvrooman May 25, 2024
8614c2a
Merge branch 'master' into bvrooman/chore/pub-snapshot-command
May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

### Changed

- [#1906](https://github.com/FuelLabs/fuel-core/pull/1906): Makes `cli::snapshot::Command` members public such that clients can create and execute snapshot commands programmatically. This enables snapshot execution in external programs, such as the regenesis test suite.
- [#1891](https://github.com/FuelLabs/fuel-core/pull/1891): Regenesis now preserves `FuelBlockMerkleData` and `FuelBlockMerkleMetadata` in the off-chain table. These tables are checked when querying message proofs.
- [#1886](https://github.com/FuelLabs/fuel-core/pull/1886): Use ref to `Block` in validation code
- [#1876](https://github.com/FuelLabs/fuel-core/pull/1876): Updated benchmark to include the worst scenario for `CROO` opcode. Also include consensus parameters in bench output.
Expand Down
6 changes: 3 additions & 3 deletions bin/fuel-core/src/cli/snapshot.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ pub struct Command {
value_parser,
default_value = default_db_path().into_os_string()
)]
pub(crate) database_path: PathBuf,
pub database_path: PathBuf,

/// Where to save the snapshot
#[arg(name = "OUTPUT_DIR", long = "output-directory")]
pub(crate) output_dir: PathBuf,
pub output_dir: PathBuf,

/// The maximum database cache size in bytes.
#[arg(
Expand All @@ -43,7 +43,7 @@ pub struct Command {

/// The sub-command of the snapshot operation.
#[command(subcommand)]
pub(crate) subcommand: SubCommands,
pub subcommand: SubCommands,
}

#[derive(Subcommand, Debug, Clone, Copy)]
Expand Down
Loading