regenesis: migrate FuelBlockIdsToHeights #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgreenx
reviewed
Apr 24, 2024
crates/storage/src/transactional.rs
Outdated
| fn commit_changes( | ||
| &mut self, | ||
| changes: Changes, | ||
| height_policy: ModifyHeightPolicy, |
There was a problem hiding this comment.
Internal details of how the database works should not affect the interfaces.
There was a problem hiding this comment.
I rewrote the PR to use a flag in the Database itself. The solution seems quite clean. Let me know what you think about this one.
Dentosal
commented
Apr 25, 2024
| @@ -16,27 +18,6 @@ use std::any::Any; | |||
| use tokio::sync::watch; | |||
| use tracing::Instrument; | |||
|
|
|||
| /// Alias for `Arc<T>` | |||
There was a problem hiding this comment.
note: moved these to a separate module for clarity
Dentosal
commented
Apr 25, 2024
| @@ -90,7 +90,10 @@ pub struct Database<Description = OnChain> | |||
| where | |||
| Description: DatabaseDescription, | |||
| { | |||
| /// Cached value from Metadata table, used to speed up lookups. | |||
There was a problem hiding this comment.
See 7b1141a#r1504911777 for the explanation behind this comment
xgreenx
reviewed
Apr 25, 2024
xgreenx
added a commit
that referenced
this pull request
Apr 29, 2024
xgreenx
approved these changes
Apr 29, 2024
Merged
xgreenx
added a commit
that referenced
this pull request
Apr 30, 2024
## Version v0.26.0 ### Fixed #### Breaking - [#1868](#1868): Include the `event_inbox_root` in the header hash. Changed types of the `transactions_count` to `u16` and `message_receipt_count` to `u32` instead of `u64`. Updated the application hash root calculation to not pad numbers. - [#1866](#1866): Fixed a runtime panic that occurred when restarting a node. The panic happens when the relayer database is already populated, and the relayer attempts an empty commit during start up. This invalid commit is removed in this PR. - [#1871](#1871): Fixed `block` endpoint to return fetch the blocks from both databases after regenesis. - [#1856](#1856): Replaced instances of `Union` with `Enum` for GraphQL definitions of `ConsensusParametersVersion` and related types. This is needed because `Union` does not support multiple `Version`s inside discriminants or empty variants. - [#1870](#1870): Fixed benchmarks for the `0.25.3`. - [#1870](#1870): Improves the performance of getting the size of the contract from the `InMemoryTransaction`. - [#1851](#1851): Provided migration capabilities (enabled addition of new column families) to RocksDB instance. ### Added - [#1853](#1853): Added a test case to verify the database's behavior when new columns are added to the RocksDB database. - [#1860](#1860): Regenesis now preserves `FuelBlockIdsToHeights` off-chain table. ### Changed - [#1847](#1847): Simplify the validation interface to use `Block`. Remove `Validation` variant of `ExecutionKind`. - [#1832](#1832): Snapshot generation can be cancelled. Progress is also reported. - [#1837](#1837): Refactor the executor and separate validation from the other use cases ## What's Changed * Weekly `cargo update` by @github-actions in #1850 * Refactor/separate validation from other executions by @MitchTurner in #1837 * fix: Use `Enum` for `ConsensusParametersVersion` and related types by @bvrooman in #1856 * feat: snapshot generation graceful shutdown by @segfault-magnet in #1832 * regenesis: migrate FuelBlockIdsToHeights by @Dentosal in #1860 * Weekly `cargo update` by @github-actions in #1869 * Refactor/Simplify validation logic by @MitchTurner in #1847 * Fixed `block` endpoint to return fetch the blocks from both databases after regenesis by @xgreenx in #1871 * Add Eq and Partial Eq to tx response and status by @MujkicA in #1872 * test: restart with relayer data by @bvrooman in #1866 * Fix `BlockHeader` hash by @MitchTurner in #1868 * Added a test for the case of adding new columns into the existing RocksDB database by @xgreenx in #1853 * Fixed benchmarks for the `0.25.3` by @xgreenx in #1870 **Full Changelog**: v0.25.3...v0.26.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1790 by completing the last missing item.
Closes #1545 by completing the last missing item as well.
This PR regenerates
FuelBlockIdsToHeightsfor both blocks on regenesis.Checklist
Before requesting review