Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove types::ConsensusParameters #1314

Merged
merged 5 commits into from
Aug 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Description of the upcoming release here.

### Changed

- [#1314](https://github.com/FuelLabs/fuel-core/pull/1314): Removed `types::ConsensusParameters` in favour of `fuel_tx:ConsensusParameters`.
- [#1302](https://github.com/FuelLabs/fuel-core/pull/1302): Removed the usage of flake and building of the bridge contract ABI.
It simplifies the maintenance and updating of the events, requiring only putting the event definition into the codebase of the relayer.
- [#1293](https://github.com/FuelLabs/fuel-core/issues/1293): Parallelized the `estimate_predicates` endpoint to utilize all available threads.
Expand Down
4 changes: 1 addition & 3 deletions bin/e2e-test-client/src/test_context.rs
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,7 @@ impl Wallet {
.chain_info()
.await
.expect("failed to get chain info")
.consensus_parameters
.into();

.consensus_parameters;
Self {
secret,
address,
Expand Down
2 changes: 0 additions & 2 deletions crates/client/src/client/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ pub mod balance;
pub mod block;
pub mod chain_info;
pub mod coins;
pub mod consensus_parameters;
pub mod contract;
pub mod gas_costs;
pub mod merkle_proof;
Expand All @@ -20,7 +19,6 @@ pub use coins::{
CoinType,
MessageCoin,
};
pub use consensus_parameters::ConsensusParameters;
pub use contract::{
Contract,
ContractBalance,
Expand Down
6 changes: 2 additions & 4 deletions crates/client/src/client/types/chain_info.rs
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
use crate::client::{
schema,
types::{
Block,
ConsensusParameters,
},
types::Block,
};
use fuel_core_types::fuel_tx::ConsensusParameters;

pub struct ChainInfo {
pub base_chain_height: u32,
Expand Down
179 changes: 0 additions & 179 deletions crates/client/src/client/types/consensus_parameters.rs

This file was deleted.

4 changes: 2 additions & 2 deletions tests/tests/chain.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ async fn chain_info() {
assert_eq!(node_config.chain_conf.chain_name, chain_info.name);
assert_eq!(
node_config.chain_conf.consensus_parameters,
chain_info.consensus_parameters.clone().into()
chain_info.consensus_parameters.clone()
);

assert_eq!(
node_config.chain_conf.consensus_parameters.gas_costs,
chain_info.consensus_parameters.gas_costs.into()
chain_info.consensus_parameters.gas_costs
);
}