Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update benchmark to include the worst scenario for CROO opcode #1660

Closed
xgreenx opened this issue Feb 12, 2024 · 0 comments · Fixed by #1876
Closed

Update benchmark to include the worst scenario for CROO opcode #1660

xgreenx opened this issue Feb 12, 2024 · 0 comments · Fixed by #1876
Assignees
@xgreenx

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Feb 12, 2024 •
edited by bvrooman
Loading

We need to update benchmark to include the worst scenario for CROO opcode after modification from FuelLabs/fuel-vm#673
@xgreenx xgreenx changed the title Update benchmark to include the worst scenario for CRO opcode Update benchmark to include the worst scenario for croo opcode Feb 12, 2024
@xgreenx xgreenx changed the title Update benchmark to include the worst scenario for croo opcode Update benchmark to include the worst scenario for CROO opcode Feb 12, 2024
@bvrooman bvrooman mentioned this issue Feb 14, 2024
Merged
@xgreenx xgreenx mentioned this issue May 2, 2024
Merged
1 task
@MitchTurner MitchTurner assigned xgreenx and unassigned bvrooman May 2, 2024
xgreenx added a commit that referenced this issue May 3, 2024
@xgreenx
Updated croo opcode benchmark to depend on the contract size (#1876)
6abbab1 
Closes #1660

The PR also adds a `consensus-parameters` type support in the `collect`
binary to simplify updating of the chain config.

### Before requesting review
- [x] I have reviewed the code myself
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xgreenx xgreenx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated croo opcode benchmark to depend on the contract size FuelLabs/fuel-core
2 participants
@bvrooman @xgreenx