Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate why connections close in discovery_works test #1562

Closed
MitchTurner opened this issue Dec 18, 2023 · 1 comment · Fixed by #1879
Closed

Investigate why connections close in discovery_works test #1562

MitchTurner opened this issue Dec 18, 2023 · 1 comment · Fixed by #1879
Assignees
@xgreenx

Comments

@MitchTurner
Copy link
Member

This test shows that a set of n nodes can all peer with each other, starting with each only knowing the one bootstrap node.

For some reason when we upgraded libp2p, our nodes became much flakier during this tests. They can all successfully find each other, but they will spuriously close connections and we don't know why. We were able to get the test to pass by being somewhat liberal about how often the nodes can connect, but this is sub-optimal. We'd prefer to keep parity with the old test, where the connections were strong.
@MitchTurner MitchTurner mentioned this issue Dec 18, 2023
Merged
@MitchTurner
Copy link
Member Author

@xgreenx might have a solution

@xgreenx xgreenx mentioned this issue May 2, 2024
Merged
1 task
xgreenx added a commit that referenced this issue May 6, 2024
@xgreenx
Return the old behaviour for the discovery_works test (#1879)
3894ef2 
Closes #1562

I put the test into the infinite loop for 20 minutes, and it is not
failing anymore.


### Before requesting review
- [x] I have reviewed the code myself
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xgreenx xgreenx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return the old behaviour for the discovery_works test FuelLabs/fuel-core
2 participants
@MitchTurner @xgreenx