-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distinction between consecutive tasks #20
Comments
For now, pull request #19 implements a distinction by adding an overline on every other consecutive task. This is how it looks with #19 : Unfortunately putting boxes around blocks will not work, because emacs fuses them even if they are different colors. Putting a zero-width box around every other block almost works, but it still messes with the alignment and makes the timeline unreadable. |
Hey @aizensoosuke. Thanks for this
Interesting. For some reason the overline is hard to see in my case.
Oh, I was thinking if we could somehow reduce the end time for the duration by a minute while rendering the block then we could get the desired result. This reduction should only happen when rendering that block and not when detecting the overlap. So for this org file
If we change the end time for Task1 to 10:59 we will get a single character gap You seem to be better equipped to answer if such an implementation is feasible. |
This is possible, I'll implement it quickly as an option. The problem with this is that you won't be able to differentiate between blocks that last a whole hour and blocks that are a little than more 40 minutes. That is because each hour is divided into 6 blocks of 10min that can't be divided. It will also delete very short blocks that would otherwise be rendered, but are directly followed by another block. |
I think this solution is less than ideal. It was requested in issue Fuco1#20.
I'm letting you know that I implemented it. You'll have to setq |
The way we're checking for overlaps makes this break |
I just noticed you pushed another commit. It seems to work with that. Thank you for the effort @aizensoosuke 😄. I'm impressed with your speed to implement this. The only issue that now remains for me it seems is that the blocks don't perfectly align with the time slots. Maybe I should create another issue for this. The |
Not really, what I did makes all the starting times shift.
Yes, I'm fixing this, I should push the fix in a couple minutes. |
Thank you! I happened to need the exact same thing you needed just today, so I was already working on it anyway. I noticed your issue only after.
Glad to help! It should be working by now 👌 |
Do you mean the alignment of blocks in timeslots? That still doesn't seem to work for me, if that's the case. The gaps work perfectly for me though. 👍 |
Did you use the last commit to #19? If so, could you show me a screeshot? |
Oh sorry, we're talking about separate issues! I read too fast. I had introduced a bug that shifted start times of blocks with my implementation of space-out-consecutive. That is fixed now. What you're talking about is, indeed, a separate issue. We could probably change it by using a different character for the vertical separation of hours, but it would be pretty asymmetrical and I'm not sure that would please the eye.
This was a choice made by @Fuco1. I'll let him decide if he wants to keep it, but I think you're right. I'll implement that later, unless @Fuco1 has an objection. |
I realized it was just 2 characters in the code, so here you go. See #19 |
Awesome, it works fairly well. Although, the end moves 1 offset forward as well Anyways, thank for all the help. |
This should probably happen at this point. What you're asking for is that events fit in their slot only if they're one hour long and start at an o'clock time? (when (and (eq (mod beg 60) 0) (eq (mod end 60) 0))
(setq end-pos (- end-pos 1))
(setq block-length (- block-length 1))) after line 442 of org-timeline.el. |
So, to go back to the initial topic of this issue, I think having a separating character might make this clearer than it currently is. Maybe just having the overline making consecutive events distinct is the way to go. @Fuco1 |
Hello Matus,
Thank you for writing this package.
Is it possible to add a small gap between consecutive tasks so that distinction can be made among them?
This is done in google calendar by always adding a pixel or two of whitespace in the end
This is not apparent when looking at the org-timeline view
The 10:30AM-12AM window in this case has two tasks in it, which isn't clear unless we hover on them.
I personally use two colors alternatively in my agenda view to create slight distinction in the agenda log.
Incorporating the gap would make it much cleaner, though I'll be happy to have the alternative color hack as well, in the case where implementing the former is very complicated :)
Thanks.
The text was updated successfully, but these errors were encountered: