fix(vite): e2e fixes for crystal #8
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandarini
commented
Jan 31, 2024
| @@ -78,40 +77,4 @@ describe('@nx/vite/plugin', () => { | |||
| } | |||
| }); | |||
| }); | |||
|
|
|||
| describe('react with vitest only', () => { | |||
There was a problem hiding this comment.
Not needed for e2e. This can be checked within unit tests, and is indeed being checked in unit tests.
mandarini
commented
Jan 31, 2024
| @@ -68,84 +65,12 @@ describe('Vite Plugin', () => { | |||
| expect(fileExists(`dist/apps/${myApp}/package.json`)).toBeFalsy(); | |||
| rmDist(); | |||
| }, 200_000); | |||
|
|
|||
| it('should build application with new package json generation', async () => { | |||
| runCLI(`build ${myApp} --generatePackageJson`); | |||
There was a problem hiding this comment.
generatePackageJson not supported by vite natively
mandarini
commented
Jan 31, 2024
| }); | ||
|
|
||
| 100_000; | ||
| }); | ||
|
|
||
| describe('incremental building', () => { |
There was a problem hiding this comment.
change this test to just test the building of dependencies
mandarini
commented
Jan 31, 2024
| @@ -302,59 +198,6 @@ export default App; | |||
| expect(directoryExists(coverageDir)).toBeTruthy(); | |||
| }, 100_000); | |||
|
|
|||
| // TODO: This takes forever and times out everything - find out why | |||
There was a problem hiding this comment.
We are not using the @nx/vitest executor any more. so this test is not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix vite e2e for project crystal.
I removed the following:
--buildLibsFromSource--generatePackageJson