Allow config files to be organized in multiple directories #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or model and settings paths
This is to be consistent with an earlier pull request for compatibility with Laravel 5.2
|
Some additional commit I made after I generated the pull request got pulled into the pull request, too. The last two commits are not about the config file changes, but are to allow the edit_fields section of the model config to be optional (I have a use case where I want custom actions but no direct editing of fields). I hadn't thought those would get pulled in since I committed them after the pull request. Sorry about that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm writing some packages that I wanted to host their own model and setting config files. The changes in this pull request expand the model_config_path and settings_config_path options to accept an array of directories. The directories are searched for config files in order, and the first match is used. This allows an application to override a package's config files if needed.
This is fully backward compatible, a simple non-array path will still work for both model_config_path and settings_config_path.
This pull request includes updates to the tests and docs for this change.
Also in this pull request, but not critical, is the Request::url () change to allow Laravel 5.2 compatibility.