Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add possibility to use a callback function as naming attribute for images #1000

Open
wants to merge 24 commits into
base: dev
Choose a base branch
from

Conversation

ckilb
Copy link

@ckilb ckilb commented Mar 17, 2016

No description provided.

@ckilb
Copy link
Author

ckilb commented Mar 17, 2016

This pull requests makes it possible to use a callback function for the naming option for images ("keep" vs callback function vs anything else for random).
For this I've moved the logic for generating random file names from the Multup class into the File.php class. I think it would be a good idea to get completely rid of the Multup class :) Like you said in one of the commits, it's a disaster ;)
I wasn't sure if the file name generation still should belong to the File Field class. But I think it's still fine to have this being part of the responsibility for this class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant