Copy comment from previous week's timesheet #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
merged commit 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Make it possible for previous week's comment to be carried over when copying the week's timesheet
Related issues
#130
Added
Action that retrives a single timesheet based on employee and interval, and stores it to previousTimeSheet in store.
The more generic action would override the currently created timesheet with the old values, including the status. Rewriting it to match the new usecase risks breaking functionality, so I went with extending to a more specific scenario.
Changed
useTimesheets.ts #copyPreviousWeek now dispatches an event to retrieve previous timesheet. The #message is updated previousTImesheet alongside timesheet updates.
How to test
Fill in a week including a message.
Copy the week's values into a new timesheet
Note the comment persists into the new timesheet too.
Fill in a week without a message
Copy the week's values into a new timesheet
Note the comment empty.