Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proton-TKG: Add experimental support for umu-launcher #1283

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Artewar67
Copy link
Contributor

It adds the following things:

Modifies the proton startup script to run correctly with umu-launcher

Adds umu-protonfixes that are needed for the launcher to work.

Changes the version of the Steam runtime library to Sniper

Also another question: I want to change the version of Proton to 9, but there is a question. Are there any problems with this version?

This need for working umu-launcher

Signed-off-by: Kirill Artemev <[email protected]>
For working need to export UMU_NO_RUNTIME=pressure-vessel to work

Signed-off-by: Kirill Artemev <[email protected]>
Signed-off-by: Kirill Artemev <[email protected]>
You need to use sniper runtime to run umu launcher

I also don't know why we are still using version 8 of proton

Signed-off-by: Kirill Artemev <[email protected]>
@Artewar67
Copy link
Contributor Author

Artewar67 commented Oct 9, 2024

To run with umu-launcher you also need to put the environment variable UMU_NO_RUNTIME="pressure-vessel" so that it would start.

@loathingKernel
Copy link
Contributor

loathingKernel commented Oct 9, 2024

To run with umu-launcher you also need to put the environment variable UMU_NO_RUNTIME="pressure-vessel" so that it would start.

This env variable disables the use of Sniper runtime in umu. Umu presently consider this a debugging-only feature. If it is required for proton-tkg to work with umu, it is likely that it is not being built in the runtime correctly.

@Artewar67
Copy link
Contributor Author

This env variable disables the use of Sniper runtime in umu. Umu presently consider this a debugging-only feature. If it is required for proton-tkg to work with umu, it is likely that it is not being built in the runtime correctly.

The problem is that wine, dxvk and vkd3d are still being built against the system libraries and compiler in our script, and this prevents umu-launcher from running it #1202 Open-Wine-Components/umu-launcher#99

Need to change the build script so that proton-tkg is built against steam runtime. In the meantime, umu launcher support is currently implemented rather poorly and experimentally.

@loathingKernel
Copy link
Contributor

That makes sense. What I find odd is setting the required_tool_appid in toolmanifest.vdf to Sniper. This will cause these builds to not work in Steam as Steam will force Sniper in this case. So I am a bit confused what was the intention here.

@Artewar67 Artewar67 closed this Oct 13, 2024
@Artewar67 Artewar67 deleted the proton-umu-launcher branch October 13, 2024 09:16
@Artewar67 Artewar67 restored the proton-umu-launcher branch October 13, 2024 09:16
@Artewar67
Copy link
Contributor Author

I apologize for accidentally removing the branch.

@Artewar67 Artewar67 reopened this Oct 13, 2024
@Tk-Glitch
Copy link
Member

I apologize for accidentally removing the branch.

No worries :)

@Tk-Glitch
Copy link
Member

Tk-Glitch commented Oct 14, 2024

Proton 9 is quite robust these days, but the tooling is an issue on our end on the build script part. The building approach changed at some point on experimental 8 and until we can properly build against it (I failed to fix this til now, and lower availability hasn't helped) we're enforcing the commit before those breaking changes for the tooling:

# Tooling compilation needs an update for latest BE - Use slightly older tooling for now
if [ -n "$_bleeding_tag" ] || [[ "$_proton_branch" = experimental_8* ]] || [[ "$_proton_branch" = *9* ]]; then
git checkout f5e9c76903e4e18e0416e719a6d42d0cb00998aa
fi

So changing the tooling branch effectively has no effect currently on Proton 8 (exp or be) and 9 (any).

The _nosteamruntime thingy should break more than it fixes in its current form so I'm intrigued. Did you test this successfully against various games?

@Artewar67
Copy link
Contributor Author

Artewar67 commented Oct 15, 2024

I used proton-tkg from the upstream wine branch and which games worked and which still need something else customized

Two games on Unity: No problems, everything started correctly.

Barony: No problems either

Pacific Drive (UE4): Game crashes because when running umu-launcher proton-tkg VKD3D_FEATURE_LEVEL was set to 12_1 but my video card doesn't support rtx and I had to set 12_0 myself to get the game to start up. Also game need vcrun2019 or vcrun2022

Stalker Anomaly: The game needs to install d3dx* and d3dcompiler_* via winetricks to run.

@Artewar67
Copy link
Contributor Author

I also found one problem

My patch caused regression and in the file compatibiltytool.vdf the proton version is not written and the default TKGVERSION is left

@Tk-Glitch
Copy link
Member

Weird. Will check that out too. Thanks Artewar67!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants