For CI build, part 2

[FrogTheFrog]

No description provided.

[moi952]

Hi,
Thanks for your help :)
So for the switch to the right screen it works, I was trying to stream in 140 fps but I had planned a matching for 144 => 60 ...

However with this update the stream freezes and works again every 10/20 seconds.

clients :
macOs with M1
Laptop with 5400u

[FrogTheFrog]

Hi, Thanks for your help :) So for the switch to the right screen it works, I was trying to stream in 140 fps but I had planned a matching for 144 => 60 ...

However with this update the stream freezes and works again every 10/20 seconds.

clients : macOs with M1 Laptop with 5400u

I think the stream freezes are unrelated to my changes. You should disable my changed via the first configuration option. Enable both displays in Windows and see if the problem still occurs.

[moi952]

Hi, Thanks for your help :) So for the switch to the right screen it works, I was trying to stream in 140 fps but I had planned a matching for 144 => 60 ...
However with this update the stream freezes and works again every 10/20 seconds.
clients : macOs with M1 Laptop with 5400u

I think the stream freezes are unrelated to my changes. You should disable my changed via the first configuration option. Enable both displays in Windows and see if the problem still occurs.

Ok, I checked and I have the problem when I disable the option.

You are up to date on master, so a priori there would be a bug on the pre-release.

I have to create an issue on sunshine is that right?

Thanks :)

[FrogTheFrog]

Before you do that, please also try the official pre-release build

[moi952]

Before you do that, please also try the official pre-release build

It does the same thing to me on the pre-release.

[FrogTheFrog]

Then please do create and issue and maybe talk about it on discord

[moi952]

Hi @FrogTheFrog , could you rebase master on your project, cgutman fixed the freeze issue I had on my AMD GPU in this PR.
LizardByte/build-deps#365

Thanks a lot 😀

[comsyspro]

Yes, I already did this std::make_unique<PersistentState>(nullptr), and no display_device.state file is created then. I think setting dd_configuration_option=disabled will also disable all such persitent-functions and will also not produce the display_device.state file and this was my question if it is behaving like this. So if that's true it's easier to disable it by dd_configuration_option=disabled.

[FrogTheFrog]

dd_configuration_option=disabled

This will disable all of the new functionality too. There is no point in using this build then.

While the file is not created, it still stays in the Sunshine's memory. In the same comment from before, I have added a link on how you can completely disable it if you wish. I do not guarantee that it will not break anything though...

[comsyspro]

Ok, thank you for the explanation. But there is the change with the new deviceid which I can use but I don't need the other dd_configuration code. As mentioned I'm using a multimonitor setup which will have issues when enabling dd_configuration in some cases.

[FrogTheFrog]

Ok, thank you for the explanation. But there is the change with the new deviceid which I can use but I don't need the other dd_configuration code. As mentioned I'm using a multimonitor setup which will have issues when enabling dd_configuration in some cases.

I this case you can just disable it. The deviceid-only change is also already in the Sunshine's main branch, FYI.

[moi952]

Hi,

1. I just reinstalled the latest version and the framerate and resolution matching no longer works.

I configured it so that if I request 140 or 144 the screen is configured to 120hz but it no longer works.

On the other hand, if I configure 120 in my moonlight client it works fine, so it's not a problem with my screen.

I have "Optimize game settings for streaming" checked in moonlight.

Oh yes and in the sunshine logs, if I request in 140, I have as value of "Requested frame rate [60fps]" but if I request in 120 I have "Requested frame rate [120fps]"

2. Also I would have a proposal that could simplify the configuration for a large number of people, would it not be interesting to propose an option:

"if the framerate is higher than X hz request X hz"

For example everything that is requested at more than 120, it configures the screen at 120.

Thanks

[FrogTheFrog]

Hi,

1. I just reinstalled the latest version and the framerate and resolution matching no longer works.

I configured it so that if I request 140 or 144 the screen is configured to 120hz but it no longer works.

On the other hand, if I configure 120 in my moonlight client it works fine, so it's not a problem with my screen.

I have "Optimize game settings for streaming" checked in moonlight.

Oh yes and in the sunshine logs, if I request in 140, I have as value of "Requested frame rate [60fps]" but if I request in 120 I have "Requested frame rate [120fps]"

2. Also I would have a proposal that could simplify the configuration for a large number of people, would it not be interesting to propose an option:

"if the framerate is higher than X hz request X hz"

For example everything that is requested at more than 120, it configures the screen at 120.

Thanks

1. Post the logs
2. I will not be working on any new features until everything that I have is merged.

[moi952]

Hi,

1. I just reinstalled the latest version and the framerate and resolution matching no longer works.

I configured it so that if I request 140 or 144 the screen is configured to 120hz but it no longer works.
On the other hand, if I configure 120 in my moonlight client it works fine, so it's not a problem with my screen.
I have "Optimize game settings for streaming" checked in moonlight.
Oh yes and in the sunshine logs, if I request in 140, I have as value of "Requested frame rate [60fps]" but if I request in 120 I have "Requested frame rate [120fps]"

2. Also I would have a proposal that could simplify the configuration for a large number of people, would it not be interesting to propose an option:

"if the framerate is higher than X hz request X hz"
For example everything that is requested at more than 120, it configures the screen at 120.
Thanks

1. Post the logs
2. I will not be working on any new features until everything that I have is merged.

What level of logs do you need?

Info? Debug?

When I looked I didn't find any reference to 140. It says I'm requesting in 60 when I'm requesting in 140.

For the addition of the higher matching, I understand.

But what do you think of the idea? It seems rather interesting to me and it will be used by many people since the dummy plugs are often at 60hz. It will avoid doing several matchings.

[FrogTheFrog]

Verbose logs please.

The idea is good.

[moi952]

Verbose logs please.

The idea is good.

I made a connection in 120 which worked and one in 140 which did not work (it should have made the matching between 140 and 120)
sunshine - Copie.txt

sunshine.log

[FrogTheFrog]

Verbose logs please.
The idea is good.

I made a connection in 120 which worked and one in 140 which did not work (it should have made the matching between 140 and 120) sunshine - Copie.txt

sunshine.log

Get the new build once it's done cooking. Had deleted a single line by accident 3 weeks ago that actually loads the remapping config.

[moi952]

Verbose logs please.
The idea is good.

I made a connection in 120 which worked and one in 140 which did not work (it should have made the matching between 140 and 120) sunshine - Copie.txt
sunshine.log

Get the new build once it's done cooking. Had deleted a single line by accident 3 weeks ago that actually loads the remapping config.

Thanks ! It work perfectly again !

[lyndonguitar]

Hi, I'm using the latest version of this build (windows)
I am running into problems where a non-HDR client will turn off my HDR host as requested/expected, but upon full disconnect, it will not turn back on the HDR. (both are at 4K).

I uploaded the sunshine logs where I did a connect+disconnect, there's lots of other chatter the crowded the text file btw.

sunshine log.txt

I also tried tweaking with these settings

[FrogTheFrog]

@lyndonguitar Please try the latest build, it has some additional logs. Give me new Sunshine logs please (info level is enough).

[FrogTheFrog]

Closing this PR as it's going into Sunshine. @moi952 your "equal, lower, more" will not make it into the release, but soon after it will probably be in a nightly.

[moi952]

Closing this PR as it's going into Sunshine. @moi952 your "equal, lower, more" will not make it into the release, but soon after it will probably be in a nightly.

Ok! great thanks a lot for the information. Great I will follow your PR. Thank you very much for your work