Use platform agnostic StartsWith null check #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found on OSX Catalina w/ .NET Core 3.1:
`StartsWith("\0")` always returns `true`
Implemented fix from the following discussion:
https://stackoverflow.com/questions/52395504/inconsistent-string-startswith-on-different-platforms
jacobx1
commented
Nov 10, 2020
| @@ -170,7 +170,7 @@ private async Task Run(CancellationToken token) | |||
|
|
|||
| var jsonString = await _proxy.GetMessageAsString(token); | |||
|
|
|||
| if (!string.IsNullOrEmpty(jsonString) && !jsonString.StartsWith("\0")) | |||
| if (!string.IsNullOrEmpty(jsonString) && !jsonString.StartsWith("\u0000", StringComparison.OrdinalIgnoreCase)) | |||
There was a problem hiding this comment.
Note - if this lib is updated to .NET Standard 2.1, .StartsWith('\0') would work here as well. Decided to go with this change to prevent needing dependents to update.
|
Looks like a good fix! Thank you for sending this update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found on OSX Catalina w/ .NET Core 3.1:
StartsWith("\0")always returnstrueImplemented fix from the following discussion:
https://stackoverflow.com/questions/52395504/inconsistent-string-startswith-on-different-platforms