PHP 8 rector recommended changes

[franzholz]

Applied rules:

• RemoveUnusedVariableInCatchRector (https://wiki.php.net/rfc/non-capturing_catches)
• ClassPropertyAssignToConstructorPromotionRector (https://wiki.php.net/rfc/constructor_promotion Implement "Constructor Promotion" php/php-src#5291)
• StrContainsRector (https://externals.io/message/108562 Create str_contains PHP function php/php-src#5179)

[bmack]

This can only be merged if we only support PHP 8+ (which I guess is only possible if we drop v10+v11 support). to be honest, for most of the changes, I don't see a benefit for the code base.

[franzholz]

It is time to require PHP 8 as a minimum.

[ohader]

Actually it's time to get rid of $GLOBALS['TYPO3_DB'] and migrate to use Doctrine DBAL (which was introduced with TYPO3 v8 in 2016: https://docs.typo3.org/m/typo3/reference-coreapi/11.5/en-us/ApiOverview/Database/Migration/Index.html

[franzholz]

More years are needed to get all the extensions to Doctrine DBAL. extensions.typo3.org shows still more than 8000 downloads in February 2024.

[bmack]

@franzholz still, can you update the branch to only allow PHP 8 in composer.json?

[franzholz]

I have updated nowe the php8-rector branch to require PHP 8 and TYPO3 12.

[sgrossberndt]

I don't endorse this change as removing the backwards compatibility on a legacy extension meant to ease migrating to QueryBuilder really doesn't seem sane. On the other hand supporting TYPO3 9.4-12 in this extension would make it less maintainable.

[sgrossberndt]

Conflicting outdated version requirement

[sgrossberndt]

Also this change is based on an outdated state of the extension and cannot be merged

[sgrossberndt]

Franz, I understand you work on this extension in order to gain TYPO3 v12 support for EXT:tt_products, but as even your extension in the current state supports TYPO3 v10+ - all of your supported TYPO3 versions do support QueryBuilder and instead of dedicating work into making typo3db_legacy on newer TYPO3 versions you should focus on making tt_products work with QueryBuilder instead.

[franzholz]

Yes, of course I should invest many hours in dozens of extensions. Obviously you have not noticed many other extensions which I maintain. However it just takes to much time to get them ajll there. This is not the only thing which must be done one day. There are so many other reprogramming issues and bug fixings to do.

[franzholz]

I have made a new patch for rector under PHP 8.