fix symfony 4 compatibility

FriendsOfSymfony · Aug 2, 2024 · 8335e8f · 8335e8f
1 parent 06bf3a5
commit 8335e8f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,14 @@ See also the [GitHub releases page](https://github.com/FriendsOfSymfony/FOSHttpC
 2.x
 ===
 
+2.16.1
+------
+
+### Fixed
+
+* The new `EventDispatchingHttpCache::forward` method added in 2.16.0 was not
+  compatible with Symfony 4.4. Adjusted the signature to make it compatible.
+
 2.16.0
 ------
 

diff --git a/src/SymfonyCache/EventDispatchingHttpCache.php b/src/SymfonyCache/EventDispatchingHttpCache.php
@@ -130,7 +130,7 @@ protected function invalidate(Request $request, $catch = false): Response
         return parent::invalidate($request, $catch);
     }
 
-    protected function forward(Request $request, bool $catch = false, ?Response $entry = null): Response
+    protected function forward(Request $request, $catch = false, ?Response $entry = null): Response
     {
         // do not abort early, if $entry is set this is a validation request
         $this->dispatch(Events::PRE_FORWARD, $request, $entry);