feat: add cache for health ping #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frosh-automation fix-cs |
|
@frosh-automation create-instance |
|
Hey 👋, I have created for you an Shopware Instalation with the current changes made here. You can access the Shop here: https://o1jr6k8-4udapafak0fe0.zrh1.namespaced.app The URL is only for FriendsOfShopware members. |
schneider-felix
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having multiple users in admin will result in health check performed multiple times within seconds.
I used 59 seconds for cache time because the status is taken every 60 seconds, and I want to make that there are not two pings of the same user getting the same cached response.