New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: collection might contain null values when eager loading #359

Merged

SychO9 merged 1 commit into master from sm/filter-collection-before-eager-loading

Nov 12, 2023

Contributor

SychO9 commented Nov 12, 2023

Changes proposed in this pull request:
Plucking seems to include null values as well, so we need to filter the collection.

Confirmed

Frontend changes: tested on a local Flarum installation.
Backend changes: tests are green (run composer test).

Required changes:

Related Flarum core extension PR's: (Omit this section if irrelevant)


          fix: collection might contain null values when eager loading

7f4e6a3

SychO9 merged commit fce3d0f into master

6 checks passed

SychO9 deleted the sm/filter-collection-before-eager-loading branch

November 12, 2023 16:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet