Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cake 5 #335

Merged
merged 18 commits into from
Sep 13, 2023
Merged

Cake 5 #335

merged 18 commits into from
Sep 13, 2023

Conversation

ADmad
Copy link
Member

@ADmad ADmad commented Sep 13, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 82.60% and project coverage change: -2.30% ⚠️

Comparison is base (d99b5c7) 92.94% compared to head (4bcf285) 90.65%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #335      +/-   ##
============================================
- Coverage     92.94%   90.65%   -2.30%     
+ Complexity      225      222       -3     
============================================
  Files            19       19              
  Lines           652      642      -10     
============================================
- Hits            606      582      -24     
- Misses           46       60      +14     
Files Changed Coverage Δ
src/Manager.php 97.77% <ø> (ø)
src/Model/Filter/Boolean.php 79.16% <ø> (-20.84%) ⬇️
src/Model/Filter/Compare.php 73.33% <ø> (ø)
src/Model/Filter/Escaper/DefaultEscaper.php 100.00% <ø> (ø)
src/Model/Filter/Exists.php 79.16% <ø> (ø)
src/Model/Filter/Value.php 81.81% <0.00%> (-15.16%) ⬇️
src/Processor.php 97.05% <ø> (ø)
src/SearchPlugin.php 100.00% <ø> (ø)
src/View/Helper/SearchHelper.php 100.00% <ø> (ø)
src/Model/Filter/Base.php 92.85% <60.00%> (ø)
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ADmad ADmad merged commit acf6cde into master Sep 13, 2023
@ADmad ADmad deleted the cake-5 branch September 13, 2023 16:46
@fr3nch13
Copy link
Contributor

Does this mean the master branch is CakePHP 5.x compatible?

@dereuromark
Copy link
Member

You can open master composer json and check yourself:

"cakephp/cakephp": "^5.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants