-
-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes jumping lines #4782
fixes jumping lines #4782
Conversation
Nord theme is still jumping for me (Firefox and Chrome on Windows 10, 100%), all the other themes are better again 👍🏻 |
I have troubles applying the patch:
|
I got it working by going back to a previous commit. I didn't browse through all the themes but it looks good to me! (origine-compact, flat, pafat, and even nord) |
Thank you @Alwaysin for your tests! That's appreciated. |
@Alwaysin If you have checked out FreshRSS by git, the easiest is to continue using git for trying features and going back # Get back to clean edge
git fetch --all --prune
git reset --hard upstream/edge
# Apply a patch
git pull https://github.com/math-GH/FreshRSS.git fix-jumping-lines (Using the convention that Command-line tips can be found at the bottom of GitHub pull requests: |
Thanks for the info @Alkarex. I indeed am on git and it usually works with I think you need to have specific rights to see wht is on your screenshot, I don't see this. But the instructions otherwise work though! |
I fixed hopefully everything. |
This PR made an issue with BlueLagoon theme visible. Please merge #4786 before |
* fixes * fix template * fix frss.css * fix Nord theme
Closes #4698
hopefully I fix the issue on the root.
Unfortunately I had to use line-height with
rem
unit.Pull request checklist: