Mapco text display improvements #4711
Conversation
|
ouch, automated testing is demanding, i got errors on minor things (from my point of view). should i fix everything for this PR to be accepted ? |
|
The easiest is to run |
Yes, it whines about it so I don't have to whine about it. ;-P |
|
i'm struggling with the |
p/themes/Mapco/mapco.rtl.css
Outdated
|
|
||
| .icon { | ||
| height: inherit; | ||
| } |
There was a problem hiding this comment.
I guess you forgot to commit mapco.scss, that inserts this lines into the CSS file.
I would suggest to do another PR for changing the width/height behavior of .icon and its height. Let's do not do it with this PR. I can support you with a PR.
| height: 1rem; | ||
| height: inherit; |
|
It is fine for me how it is now |
* Main font color from blue to regular dark * newline added at the end of rtl css file * Text display improvements (code, quotes) + minor UI fixes * replaced 2 spaces with 1 tab bcz phpcs is whining about that * make fix-all * Mapco/base-theme - CSS cleaning * make fix-all * PR FreshRSS#4711 cleaning * Exclude generated CSS from lint check * Revert exclusion of generated CSS files Co-authored-by: patjennings <[email protected]> Co-authored-by: Alexandre Alapetite <[email protected]> Co-authored-by: patjennings <[email protected]> Co-authored-by: maTh <[email protected]>
Closes #4695