Slider: Block Page for one scrollbar; Scrollbar width normal #4692
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
As soon as the sidebar is opened, the content on the main page is blocked so that a second scrollbar does not appear, because the page is no longer scrollable.
Why make the scrollbar smaller? I think the content in the slider is long and sometimes the scrollbars are small enough.
How to test the feature manually:
Go to main page
Click on the gear next to a feed, then manage to open the slider
Go to main page
Click on "Subscription Management"
Click on the gear next to a feed to open the slider
I've tested it, but it's better if someone double checks since I'm new to the project.
Tested in Theme: Origine (and some randomly)
Pull request checklist:
This shouldn't affect the tests, but since it throws bugs in the edge branch as well, just for documentation.
Test command executed:
NO_DOCKER=true make test