Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider: Block Page for one scrollbar; Scrollbar width normal #4692

Merged
merged 6 commits into from
Oct 5, 2022

Conversation

Cyb10101
Copy link
Contributor

@Cyb10101 Cyb10101 commented Oct 5, 2022

Changes proposed in this pull request:

  1. As soon as the sidebar is opened, the content on the main page is blocked so that a second scrollbar does not appear, because the page is no longer scrollable.

  2. Why make the scrollbar smaller? I think the content in the slider is long and sometimes the scrollbars are small enough.

How to test the feature manually:

  1. Go to main page

  2. Click on the gear next to a feed, then manage to open the slider

  3. Go to main page

  4. Click on "Subscription Management"

  5. Click on the gear next to a feed to open the slider

I've tested it, but it's better if someone double checks since I'm new to the project.
Tested in Theme: Origine (and some randomly)

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (No tests needed?)
  • documentation updated (No documentation needed?)

This shouldn't affect the tests, but since it throws bugs in the edge branch as well, just for documentation.

Test command executed: NO_DOCKER=true make test

/usr/local/bin/php ./bin/phpunit --bootstrap ./tests/bootstrap.php ./tests
PHPUnit 9.5.20 #StandWithUkraine

......................................................FF....FF.  63 / 135 ( 46%)
............................................................... 126 / 135 ( 93%)
.........                                                       135 / 135 (100%)

Time: 00:00.017, Memory: 22.00 MB

There were 4 failures:

1) SearchTest::test__construct_whenInputContainsDate_setsDateValues with data set #1 ('date:2007-03-01T13:00:00Z/P1Y...T2H30M', '1172754000', '1210519799')
Failed asserting that 1210516199 matches expected '1210519799'.

/app/tests/app/Models/SearchTest.php:149

2) SearchTest::test__construct_whenInputContainsDate_setsDateValues with data set #2 ('date:P1Y2M10DT2H30M/2008-05-1...30:00Z', '1172754001', '1210519800')
Failed asserting that 1172757601 matches expected '1172754001'.

/app/tests/app/Models/SearchTest.php:148

3) SearchTest::test__construct_whenInputContainsPubdate_setsPubdateValues with data set #1 ('pubdate:2007-03-01T13:00:00Z/...T2H30M', '1172754000', '1210519799')
Failed asserting that 1210516199 matches expected '1210519799'.

/app/tests/app/Models/SearchTest.php:175

4) SearchTest::test__construct_whenInputContainsPubdate_setsPubdateValues with data set #2 ('pubdate:P1Y2M10DT2H30M/2008-0...30:00Z', '1172754001', '1210519800')
Failed asserting that 1172757601 matches expected '1172754001'.

/app/tests/app/Models/SearchTest.php:174

FAILURES!
Tests: 135, Assertions: 290, Failures: 4.
make: *** [Makefile:64: test] Error 1

@math-GH
Copy link
Contributor

math-GH commented Oct 5, 2022

Nice! And welcome!
Please add a line for you in https://github.com/FreshRSS/FreshRSS/blob/edge/CREDITS.md

@Alkarex Alkarex added this to the 1.21.0 milestone Oct 5, 2022
@Alkarex Alkarex merged commit 8920292 into FreshRSS:edge Oct 5, 2022
@Cyb10101 Cyb10101 deleted the cyb-slider branch October 6, 2022 10:12
@Alkarex Alkarex modified the milestones: 1.21.0, 1.20.1 Oct 9, 2022
math-GH added a commit to math-GH/FreshRSS that referenced this pull request Nov 15, 2022
…S#4692)

* Block page if slider is open; Hides the double page scrollbar

* Slider scrollbar default width

* Update frss.rtl.css

* Add user Cyb10101 to credits

* make fix-all

* make fix-all (second pass)

Co-authored-by: mathContao <[email protected]>
Co-authored-by: Alexandre Alapetite <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants