Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider: close via shortcut #4394

Merged
merged 5 commits into from
May 30, 2022
Merged

Slider: close via shortcut #4394

merged 5 commits into from
May 30, 2022

Conversation

math-GH
Copy link
Contributor

@math-GH math-GH commented May 28, 2022

Before:
It made me odd, that the slider cannot be closed via a shortcut (f.e. ESC).

After:
The sliders can be closed via the shortcut that closes the menu.

Additional: Via shortcut (f.e. F1), you can now open the documentation everywhere.

Changes proposed in this pull request:

  • sliders open/close via anchor (the same as the menus) (before: sliders worked only with JavaScript)
  • shortcuts are available everywhere (before: only in the feed streams)
  • HTML: slider closer is now after the slider (same as the menus)

How to test the feature manually:

  1. open the sliders (f.e. subscription management -> config a feed or category; or config an extension manager ->config an extension)
  2. the slider opens
  3. close the slider via "close menus" shortcut (f.e. ESC)

Pull request checklist:

  • clear commit messages
  • code manually tested

@math-GH math-GH added this to the 1.20.0 milestone May 28, 2022
p/scripts/main.js Outdated Show resolved Hide resolved
@Alkarex Alkarex merged commit 992b906 into FreshRSS:edge May 30, 2022
@math-GH math-GH deleted the slider-as-anchor branch June 8, 2022 16:40
@math-GH math-GH mentioned this pull request Jun 16, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants