Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db username regex relaxed to allow @ #3241

Merged
merged 1 commit into from
Nov 2, 2020
Merged

db username regex relaxed to allow @ #3241

merged 1 commit into from
Nov 2, 2020

Conversation

GuillaumePugnet
Copy link
Contributor

Closes #

Changes proposed in this pull request:

  • relax the regex that validates the database username during installation to allow names containing '@' , this is required to use 'Azure Database for PostgreSQL' where user names are 'user@dbname'

How to test the feature manually:
Pull request checklist:

  • clear commit messages
  • code manually tested
  • [-] unit tests written (optional if too hard)
  • [-] documentation updated

Additional information can be found in the documentation.

@Alkarex Alkarex added this to the 1.18.0 milestone Nov 2, 2020
@Alkarex Alkarex merged commit b00a06d into FreshRSS:master Nov 2, 2020
@Alkarex
Copy link
Member

Alkarex commented Nov 2, 2020

Thanks 👍 Please add a line for you in https://github.com/FreshRSS/FreshRSS/blob/master/CREDITS.md

@Alkarex Alkarex mentioned this pull request Jan 17, 2021
Closed
@Alkarex Alkarex mentioned this pull request Mar 9, 2021
Closed
@GuillaumePugnet GuillaumePugnet deleted the fix-postgresql-username branch March 31, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Security 🛡️
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@GuillaumePugnet @Alkarex @PugnetGuillaume