Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add controls on media #3036

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Conversation

aledeg
Copy link
Member

@aledeg aledeg commented Jun 5, 2020

Closes #1952

Changes proposed in this pull request:

  • Add a shortcut to control media (audio/video) from an entry

How to test the feature manually:

  1. configure properly the shortcut to your liking
  2. open a feed with a media
  3. try to play and stop the media by hitting the shortcut key

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

Additional information can be found in the documentation.

@aledeg aledeg added Shortcuts ⌨ UI 🎨 User Interfaces labels Jun 5, 2020
@aledeg aledeg added this to the 1.17.0 milestone Jun 5, 2020
p/scripts/main.js Outdated Show resolved Hide resolved
Now, there is a shortcut to play or pause media available from an
entry. If there is more than one media available, only the first
one will be targeted.

See FreshRSS#1952
@Alkarex Alkarex merged commit dc68783 into FreshRSS:master Jun 5, 2020
@aledeg aledeg deleted the feature/media-control branch June 5, 2020 21:46
@Alkarex Alkarex modified the milestones: 1.17.0, 1.16.3 Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new feature hotkey for play / pause embedded media in item
2 participants