Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose podcast in API #2898

Merged
merged 4 commits into from
Apr 16, 2020
Merged

Expose podcast in API #2898

merged 4 commits into from
Apr 16, 2020

Conversation

Alkarex
Copy link
Member

@Alkarex Alkarex commented Apr 12, 2020

Expose RSS enclosures in our API, e.g. for clients supporting podcasts:

"enclosure": [
        {
          "href": "https://audio.ausha.co/omERrsrWzE1O.mp3?t=1585735204",
          "type": "audio/mpeg",
          "length": 13721712
        }
      ],

https://blog.martindoms.com/2009/10/16/using-the-google-reader-api-part-2

View in News+
Screenshot_20200412-233915_News+

Screenshot_20200412-222914_News+

Expose RSS enclosures in our API, e.g. for clients supporting podcasts
@Alkarex Alkarex added this to the 1.17.0 milestone Apr 12, 2020
@Alkarex Alkarex added the API 🤝 API for other clients label Apr 12, 2020
@Alkarex
Copy link
Member Author

Alkarex commented Apr 12, 2020

Ping @jangernert FreshRSS is exposing Podcasts in the API. Feedback welcome

Example in FeedReader
image

P.S. It looks like there is a bug in the FeedReader's Attachments menu
image

@Alkarex
Copy link
Member Author

Alkarex commented Apr 12, 2020

Ping @barijaona I believe ViennaRSS supports enclosures, right? Feedback welcome on FreshRSS exposing them via the API

@Alkarex
Copy link
Member Author

Alkarex commented Apr 12, 2020

Ping @seazon for FeedMe Let me know whether that could enable you to show Podcasts also for FreshRSS

@Alkarex
Copy link
Member Author

Alkarex commented Apr 12, 2020

Ping @Shinokuni for Readrops

@seazon
Copy link

seazon commented Apr 14, 2020

@Alkarex Supported, since FreshRSS API is based on GoogleReader API.

@Alkarex
Copy link
Member Author

Alkarex commented Apr 16, 2020

Let's continue testing in /master. I will also make a related update to expose enclosures in our RSS outputs

@Alkarex Alkarex merged commit bdc4da6 into FreshRSS:master Apr 16, 2020
@Alkarex Alkarex deleted the forward-podcast branch April 16, 2020 16:11
@Alkarex Alkarex modified the milestones: 1.17.0, 1.16.1 Apr 24, 2020
Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Dec 14, 2022
@Alkarex Alkarex mentioned this pull request Dec 14, 2022
Alkarex added a commit that referenced this pull request Jan 6, 2023
* Better enclosures
#fix #4702
Improvement of #2898

* A few fixes

* Better enclosure titles

* Improve thumbnails

* Implement thumbnail for HTML+XPath

* Avoid duplicate enclosures
#fix #1668

* Fix regex

* Add basic support for media:credit
And use <figure> for enclosures

* Fix link encoding + simplify code

* Fix some SimplePie bugs
Encoding errors in enclosure links

* Remove debugging syslog

* Remove debugging syslog

* SimplePie fix multiple RSS2 enclosures
#fix #4974

* Improve thumbnails

* Performance with yield
Avoid generating all enclosures if not used

* API keep providing enclosures inside content
Clients are typically not showing the enclosures to the users (tested with News+, FeedMe, Readrops, Fluent Reader Lite)

* Lint

* Fix API output enclosure

* Fix API content strcut

* API tolerate enclosures without a type
cjchung pushed a commit to cjchung/FreshRSS that referenced this pull request Jan 20, 2023
* Better enclosures
#fix FreshRSS#4702
Improvement of FreshRSS#2898

* A few fixes

* Better enclosure titles

* Improve thumbnails

* Implement thumbnail for HTML+XPath

* Avoid duplicate enclosures
#fix FreshRSS#1668

* Fix regex

* Add basic support for media:credit
And use <figure> for enclosures

* Fix link encoding + simplify code

* Fix some SimplePie bugs
Encoding errors in enclosure links

* Remove debugging syslog

* Remove debugging syslog

* SimplePie fix multiple RSS2 enclosures
#fix FreshRSS#4974

* Improve thumbnails

* Performance with yield
Avoid generating all enclosures if not used

* API keep providing enclosures inside content
Clients are typically not showing the enclosures to the users (tested with News+, FeedMe, Readrops, Fluent Reader Lite)

* Lint

* Fix API output enclosure

* Fix API content strcut

* API tolerate enclosures without a type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API 🤝 API for other clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants