-
-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix favorite display for "current" articles #2634
Fix favorite display for "current" articles #2634
Conversation
I very much doubt it's on purpose. I'd change it. :-) Anyway, looks fine. Did you also test the hover behavior? It doesn't really matter if you didn't since it'll be a positive commit either way, but otherwise someone would have to do a minor follow-up still. (I already volunteered myself a few days ago.) |
7312089
to
01ce2be
Compare
01ce2be
to
8dcf20e
Compare
I fixed Ansum and Mapco as well. I wasn't sure of what should be the behaviour on hover: for the themes I patched, there is no change when the article is unread or favorite. I find it better for Ansum and Mapco because the background of the line and the background of the title are a bit de-synchronized due to the animation (at least on Firefox) |
Favorite articles have, in most of the themes, a gold background to distinguish them from the other articles. However, it can be distracting to have such a background when reading the articles, so we should turn them back to the "default" background when articles are opened (class `.current`). Bug introduced in e9ce27d Related PRs: - FreshRSS#2477 - FreshRSS#2611 - FreshRSS#2612 Closes FreshRSS#2618
8dcf20e
to
98f717f
Compare
Yep, I fixed that :) |
Favorite articles have, in most of the themes, a gold background to distinguish them from the other articles. However, it can be distracting to have such a background when reading the articles, so we should turn them back to the "default" background when articles are opened (class `.current`). Bug introduced in e9ce27d Related PRs: - FreshRSS#2477 - FreshRSS#2611 - FreshRSS#2612 Closes FreshRSS#2618
Favorite articles have, in most of the themes, a gold background to
distinguish them from the other articles. However, it can be distracting
to have such a background when reading the articles, so we should turn
them back to the "default" background when articles are opened (class
.current
).Bug introduced in e9ce27d
I didn't apply the fix to the Ansum and Mapco designs because they
already had this behaviour before the commit.
Related PRs:
Closes #2618