Batch scroll as read + reducing jQuery #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefix jQuery variables with $ Start avoiding jQuery in easy cases Use let/const
Mark-as-read requests are queued and sent max once per second
Which also simplifies the request
Alkarex
added
Work in progress 🚧
Much lighter rework: auto-mark-as-read, auto-remove-articles, auto-load-more. In particular, use a single onscroll event handler with a throtte. Continue removing jQuery when possible.
|
Resources when searching for standard JavaScript alternatives to jQuery: |
This was referenced Dec 27, 2018
Closed
|
A bit of motivation :-) https://timkadlec.com/remembers/2019-01-09-the-ethics-of-performance/ |
Funny, I never thought about performance as exclusion, but I've always thought of bad performance as a waste of my battery (and thus lifespan). |
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Jan 31, 2019
Follow-up of FreshRSS#2199
Merged
Alkarex
added a commit
that referenced
this pull request
Feb 13, 2019
* Less jQuery Follow-up of #2199 * Even less jQuery + global view unread title fix * Even less jQuery * Yet even less jQuery * Even less jQuery * Reduce some events * Even less jQuery * jQuery gone from main view +Fixed English i18n * Fix feed folded view * Remove Firefox 64 workaround Remove workaround for Gecko bug 1514498 in Firefox 64, fixed in Firefox 65 * Split to extra.js Avoid loading unneeded JavaScript code for the main view. + several adjustements * Improve CSS transition fold category * Rewrite shortcuts Remove library. Much faster, shorter, one listener instead of many. Control of the shortcut context. Fix #2215 * Remove debug * Minor syntax * Filter out unwanted shortcut modifiers * Menu overflow fix * Typo * Fix unfolding in mobile view * Remove jQuery from category.js * Remove jQuery from Global view
Merged
11 tasks
javerous
pushed a commit
to javerous/FreshRSS
that referenced
this pull request
Jan 20, 2020
Batch scroll as read + reducing jQuery
javerous
pushed a commit
to javerous/FreshRSS
that referenced
this pull request
Jan 20, 2020
* Less jQuery Follow-up of FreshRSS#2199 * Even less jQuery + global view unread title fix * Even less jQuery * Yet even less jQuery * Even less jQuery * Reduce some events * Even less jQuery * jQuery gone from main view +Fixed English i18n * Fix feed folded view * Remove Firefox 64 workaround Remove workaround for Gecko bug 1514498 in Firefox 64, fixed in Firefox 65 * Split to extra.js Avoid loading unneeded JavaScript code for the main view. + several adjustements * Improve CSS transition fold category * Rewrite shortcuts Remove library. Much faster, shorter, one listener instead of many. Control of the shortcut context. Fix FreshRSS#2215 * Remove debug * Minor syntax * Filter out unwanted shortcut modifiers * Menu overflow fix * Typo * Fix unfolding in mobile view * Remove jQuery from category.js * Remove jQuery from Global view
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
* Less jQuery Follow-up of FreshRSS#2199 * Even less jQuery + global view unread title fix * Even less jQuery * Yet even less jQuery * Even less jQuery * Reduce some events * Even less jQuery * jQuery gone from main view +Fixed English i18n * Fix feed folded view * Remove Firefox 64 workaround Remove workaround for Gecko bug 1514498 in Firefox 64, fixed in Firefox 65 * Split to extra.js Avoid loading unneeded JavaScript code for the main view. + several adjustements * Improve CSS transition fold category * Rewrite shortcuts Remove library. Much faster, shorter, one listener instead of many. Control of the shortcut context. Fix FreshRSS#2215 * Remove debug * Minor syntax * Filter out unwanted shortcut modifiers * Menu overflow fix * Typo * Fix unfolding in mobile view * Remove jQuery from category.js * Remove jQuery from Global view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overall goal is to improve performance, in particular on mobile and server-side.
In particular, this patch improves scroll performance when using the auto mark-as-read feature:
Mark-as-read requests are queued and sent max once per second. cd9a9a9
The scroll event listener is also rewritten to be much lighter caa893e
As the same time, in distinct commits, I have started some refactoring eefeb23 :
$(to distinguish them),