imx-gpu-sdk: Upgrade to 6.0.2 #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otavio
reviewed
Oct 15, 2022
Problem reported by Rasmus Villemoes <[email protected]>: ``` The imx-gpu-sdk recipe in the meta-imx layer references ${BB_NUMBER_THREADS} in its do_compile function. Changing BB_NUMBER_THREADS between bitbake invocations leads to the well-known When reparsing ...meta-imx/meta-sdk/recipes-graphics/imx-gpu-sdk/imx-gpu-sdk_5.8.0.bb:do_compile, the basehash value changed from 69be88cf220840ff2203e11cfe65681880b0bf9b88db67d50c1ba772b883bd18 to 5e6d5029fac8d7856ada4c2eca359568298f82cdb64567d7dd4deda503d9f83a. The metadata is not deterministic and this needs to be fixed. This happens because BB_NUMBER_THREADS is in BB_HASHCONFIG_IGNORE_VARS, so changing it does not cause the recipe to be reparsed, but it is not included in BB_HASHEXCLUDE_COMMON and thus BB_BASEHASH_IGNORE_VARS. ``` Fix as suggested by Richard Purdie <[email protected]>: ``` Technically imx-gpu-sdk is incorrect. BB_NUMBER_THREADS is the number of tasks bitbake should run. PARALLEL_MAKE is what is used for parallelism in do_compile. I appreciate that has -j in but you can use: ${@oe.utils.parallel_make(d)} to obtain the value that recipe needs. ``` Signed-off-by: Tom Hochstein <[email protected]>
Signed-off-by: Tom Hochstein <[email protected]>
thochstein
changed the title
otavio
approved these changes
Oct 18, 2022
|
Backport failed for Please cherry-pick the changes locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.