ipmi: Cleanup oops on initialization failure

Commit 93c303d "ipmi_si: Clean up shutdown a bit" didn't copy the behavior of the cleanup in one spot, it needed to check for a non-NULL interface before cleaning it up. Reported-by: Meelis Roos <[email protected]> Signed-off-by: Corey Minyard <[email protected]> Tested-by: Meelis Roos <[email protected]>
Freescale · Jun 24, 2018 · 2068db5 · 2068db5
1 parent 9ffc59d
commit 2068db5
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
@@ -2088,8 +2088,10 @@ static int try_smi_init(struct smi_info *new_smi)
 	return 0;
 
 out_err:
-	ipmi_unregister_smi(new_smi->intf);
-	new_smi->intf = NULL;
+	if (new_smi->intf) {
+		ipmi_unregister_smi(new_smi->intf);
+		new_smi->intf = NULL;
+	}
 
 	kfree(init_name);