This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
Add getChannelStats method #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Nov 30, 2021
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
PikachuEXE,
Hiers,
peepo5 and
kommunarr
PikachuEXE
reviewed
Jan 7, 2022
Co-authored-by: PikachuEXE <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts the following
Related issue: FreeTubeApp/FreeTube#1357
I'm not sure if these stats can be hidden or not so I have not tested this method with a channel that has it hidden (as I am not aware of any/if it's possible)
I also think that the items from this method make sense as being a part of getChannelInfo but I decided not to do it because I imagine a lot of people won't use it and it would add an extra http request to YT