Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move screenshot fallback path handling to the main process #6945

Merged

Conversation

absidue
Copy link
Member

@absidue absidue commented Feb 27, 2025

Move screenshot fallback path handling to the main process

Pull Request Type

  • Other

Description

This pull request moves the screenshot fallback path handling into the main process, that allows us to remove a use of a Node.js API in the renderer process. After this pull request the only remaining Node.js API uses in the renderer process is the video/audio/subtitle download logic.

Testing

  1. In the dev data location (Electron folder instead of the FreeTube one), check that screenshotFolderPath doesn't exist in the settings.db file, if it does remove that line.
  2. Start FreeTube
  3. Open the player settings
  4. Make sure taking screenshots is enable and ask for path is disabled.
  5. Check that it shows the correct path (should be the pictures folder in your user profile + Freetube).

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 68ec1e1

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 27, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) February 27, 2025 22:24
@FreeTubeBot FreeTubeBot merged commit feba04a into FreeTubeApp:development Mar 2, 2025
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 2, 2025
@absidue absidue deleted the screenshot-fallback-ipc branch March 2, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants