Move screenshot fallback path handling to the main process #6945
+11
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move screenshot fallback path handling to the main process
Pull Request Type
Description
This pull request moves the screenshot fallback path handling into the main process, that allows us to remove a use of a Node.js API in the renderer process. After this pull request the only remaining Node.js API uses in the renderer process is the video/audio/subtitle download logic.
Testing
screenshotFolderPath
doesn't exist in thesettings.db
file, if it does remove that line.Desktop