Fix emojis displaying incorrectly #2328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
added
the
PR: waiting for review
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
PikachuEXE
previously approved these changes
Jun 17, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Jun 19, 2022
absidue
dismissed stale reviews from efb4f5ff-1298-471a-8973-3d47447115dc and PikachuEXE
The base branch was changed.
auto-merge was automatically disabled
June 19, 2022 19:32
Pull request was closed
github-actions
bot
removed
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jun 19, 2022
PikachuEXE
approved these changes
Jun 20, 2022
|
requesting the aid of the chunkiest programmer of them all @ChunkyProgrammer |
ChunkyProgrammer
approved these changes
Jun 20, 2022
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix emojis displaying incorrectly (RC branch)
Pull Request Type
Description
Emojis are displayed incorrectly (colourless) on Windows, this pull request fixes it by adding the emoji fonts to any place in FreeTube that might contain emojis. The list of emoji fonts was taken from Bootstrap's stylesheet twbs/bootstrap - scss/_variables.scss#L543.
Screenshots (if appropriate)
Before
Search:
Channel:
Subscriptions:
Watch page:
Fullscreen player:
After
Search:
Channel:
Subscriptions:
Watch page:
Fullscreen player:
Testing (for code that is not small enough to be easily understandable)
I tested this by checking all the places that I could think of emojis showing up.
Desktop (please complete the following information):
Additional context
I decided to add the emoji fonts for other operating systems just in case, even though this is probably only an issue on Windows.