Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: loop button #2313

Merged
merged 1 commit into from
Jun 19, 2022
Merged

Fix: loop button #2313

merged 1 commit into from
Jun 19, 2022

Conversation

hockerschwan
Copy link
Contributor

Pull Request Type

  • Bugfix

Related issue
Closes #2312

Description

  1. Clear Local Storage (Developer tools -> Application)
  2. Play a video
  3. Click "Toggle loop" button
  4. Doesn't work

Screenshots (if appropriate)
z21

Desktop (please complete the following information):

  • OS: Windows10 21H1
  • FreeTube version: ae654a1

@PrestonN PrestonN enabled auto-merge (squash) June 13, 2022 07:28
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 13, 2022
auto-merge was automatically disabled June 13, 2022 23:16

Base branch changed by a user without write access

@hockerschwan hockerschwan changed the base branch from development to v0.17.0-RC June 13, 2022 23:16
@PrestonN PrestonN enabled auto-merge (squash) June 13, 2022 23:16
PikachuEXE
PikachuEXE approved these changes Jun 16, 2022
View reviewed changes
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally tested
But in #2321 (review)

@PrestonN PrestonN merged commit d1fc87d into FreeTubeApp:v0.17.0-RC Jun 19, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 19, 2022
@hockerschwan hockerschwan deleted the loop-button-fix branch June 19, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@absidue absidue absidue approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@ChunkyProgrammer ChunkyProgrammer Awaiting requested review from ChunkyProgrammer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Loop Button doesn't work
5 participants
@hockerschwan @PikachuEXE @absidue @efb4f5ff-1298-471a-8973-3d47447115dc @PrestonN