Move credentials check to be part of run-time application checks #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify the AWS client credentials check to be part of the main application (run-time check) rather than being part of the compile-time checks. This change ease the development process because it is no longer needed to modify the aws_clientcredential.h file to build the application and then revert it back when pushing the changes remotely. Signed-off-by: Ahmed Ismail <[email protected]>
AhmedIsmail02
force-pushed
the
move-credentials-check-to-runtime
branch
from
d2d6fd7 to
aa1fb28
Compare
urutva
approved these changes
Oct 30, 2023
hugueskamba
approved these changes
Oct 30, 2023
aggarg
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify the AWS client credentials check to be part of the main application (run-time check) rather than being part of the compile-time checks.
This change ease the development process because it is no longer needed to modify the aws_clientcredential.h file to build the application and then revert it back when pushing the changes remotely.
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.