Fix minor code issues #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One empty line should be added to the end of the file any other empty lines at the end of file is redundant. Signed-off-by: Ahmed Ismail <[email protected]>
Missing empty lines at the end of file are added. Signed-off-by: Ahmed Ismail <[email protected]>
AhmedIsmail02
force-pushed
the
fix-minor-code-issues
branch
from
48c08e8 to
7e028a3
Compare
aggarg
previously approved these changes
Oct 18, 2023
hugueskamba
approved these changes
Oct 18, 2023
Trailing white-spaces shouldn't be used in our code, this commit removes any trailing white-spaces. Signed-off-by: Ahmed Ismail <[email protected]>
Python code should be aligned with black styling format. This commit fixes any issues that have been detected by black formatter. Signed-off-by: Ahmed Ismail <[email protected]>
Flake aims to provide style guide enforcement, this commit applies those style guidelines whenever missing in our code. Signed-off-by: Ahmed Ismail <[email protected]>
cpp-check aims to provide unique code analysis to detect bugs, this commit fixes cpp-check findings which prevents having an undefined behaviour when executing our code. Signed-off-by: Ahmed Ismail <[email protected]>
Missing copyright headers are added to files. Signed-off-by: Ahmed Ismail <[email protected]>
AhmedIsmail02
force-pushed
the
fix-minor-code-issues
branch
from
7e028a3 to
e6ec373
Compare
urutva
approved these changes
Oct 19, 2023
aggarg
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is meant to fix minor code issues, those fixes are distributed among different commits to make it easier during the review process.
The fixes are:
Remove redundant empty lines.
Fix end of files.
Trim trailing white-spaces.
Align the python code to black and flake coding style guidelines.
Fix cppcheck warnings.
Add missing copyright headers.
Fix uncrustify code formatter findings.
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.