Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MQTT_Status_strerror to return correct error on NeedMoreBytes error #255

Merged
merged 9 commits into from
Jun 26, 2023
Merged

Fix MQTT_Status_strerror to return correct error on NeedMoreBytes error #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
55f0220
Fix timeout calculation to account for overflow
AniruddhaKanhere May 3, 2023
365fdfc
Add unit tests to check for overflow
AniruddhaKanhere May 3, 2023
b9199e4
Update timeout value in UT
AniruddhaKanhere May 4, 2023
a762194
Fix formatting
AniruddhaKanhere May 4, 2023
a03c173
Update core_mqtt_utest.c
AniruddhaKanhere May 4, 2023
4501b66
Add one more unit test to check for one corner case
AniruddhaKanhere May 4, 2023
ec5dfc5
Make unit-test more robust
AniruddhaKanhere May 4, 2023
ec344fa
Merge branch 'FreeRTOS:main' into main
AniruddhaKanhere Jun 26, 2023
b71970f
Fix MQTT_Status_strerror to return correct error on NeedMoreBytes error.
AniruddhaKanhere Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions source/core_mqtt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3373,6 +3373,10 @@ const char * MQTT_Status_strerror( MQTTStatus_t status )
str = "MQTTKeepAliveTimeout";
break;

case MQTTNeedMoreBytes:
str = "MQTTNeedMoreBytes";
break;

default:
str = "Invalid MQTT Status code";
break;
Expand Down
6 changes: 5 additions & 1 deletion test/unit-test/core_mqtt_utest.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5842,7 +5842,11 @@ void test_MQTT_Status_strerror( void )
str = MQTT_Status_strerror( status );
TEST_ASSERT_EQUAL_STRING( "MQTTKeepAliveTimeout", str );

status = MQTTKeepAliveTimeout + 1;
status = MQTTNeedMoreBytes;
str = MQTT_Status_strerror( status );
TEST_ASSERT_EQUAL_STRING( "MQTTNeedMoreBytes", str );

status = MQTTNeedMoreBytes + 1;
str = MQTT_Status_strerror( status );
TEST_ASSERT_EQUAL_STRING( "Invalid MQTT Status code", str );
}
Expand Down