Fix to update the timestamp of the last packet received #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @onkwon, Sorry for seeing this so late! Thank you for bringing this to our attention. I will take a look and notify other team members of this issue. Best, Jason Carroll |
|
Please note that this would cause customer bill increase as ping-pong every |
|
Hey, this PR needs a change in docs/doxygen/include/size_table.md (see here). If you'd prefer, I can add the change to this PR for you. Otherwise, PR looks good to me |
AniruddhaKanhere
previously approved these changes
Dec 8, 2022
There was a problem hiding this comment.
Thanks @onkwon for this PR. All looks good and I am approving this.
paulbartell
reviewed
Dec 8, 2022
Co-authored-by: Paul Bartell <[email protected]>
onkwon
requested review from
AniruddhaKanhere and
paulbartell
and removed request for
paulbartell and
AniruddhaKanhere
archigup
approved these changes
Dec 15, 2022
paulbartell
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't look like
pContext->lastPacketRxTimegetting updated anywhere. And oncePACKET_RX_TIMEOUT_MSreached the condition will always be true.