generate PINGREQ packets on idle input or output. #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbartell
reviewed
May 31, 2022
paulbartell
reviewed
May 31, 2022
paulbartell
reviewed
May 31, 2022
paulbartell
reviewed
May 31, 2022
paulbartell
reviewed
May 31, 2022
adam-scislowicz
changed the title
paulbartell
reviewed
Jun 1, 2022
paulbartell
reviewed
Jun 1, 2022
paulbartell
reviewed
Jun 1, 2022
paulbartell
reviewed
Jun 1, 2022
paulbartell
reviewed
Jun 1, 2022
paulbartell
reviewed
Jun 1, 2022
paulbartell
reviewed
Jun 1, 2022
paulbartell
reviewed
Jun 1, 2022
paulbartell
previously approved these changes
Jun 1, 2022
paulbartell
reviewed
Jun 7, 2022
paulbartell
previously approved these changes
Jun 7, 2022
adam-scislowicz
force-pushed
the
adamds/publish_retry_and_pingreq_behavior_changes
branch
2 times, most recently
from
4b0ff07 to
c1ed10b
Compare
…ions and default tieout settings.
paulbartell
force-pushed
the
adamds/publish_retry_and_pingreq_behavior_changes
branch
from
c1ed10b to
99ec326
Compare
paulbartell
approved these changes
Jul 5, 2022
ravibhagavandas
approved these changes
Jul 5, 2022
adam-scislowicz
deleted the
adamds/publish_retry_and_pingreq_behavior_changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the PINGREQ logic to send a PINGREQ not only when the client has not generated any outgoing message for the Keep Alive period (ref: 3.1.2.10 Keep Alive (http://docs.oasis-open.org/mqtt/mqtt/v3.1.1/os/mqtt-v3.1.1-os.html#_Toc385349238)). But to also generate a PINGREQ if we have not received any incoming message for the Keep Alive period, then in the case that we are continuously retransmitting a PUBLISH qos1 but receiving no ACK, we will still generate a PINGREQ after the specified Keep Alive delay. The spec explicitly allows a PINGREQ to be sent at any time and so this change in behavior maintains compliance.
Additional configuration options have been added (via the header file). This allows for the specification of different timeouts on idle transmit (TX) vs receive (RX) activity.
The smaller of the runtime configuration keepAliveTimeout and compile time transmit (TX) time timeout are used as the transmit timeout.