-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version for release #168
Changes from 6 commits
a8896a4
7f85015
fbf8111
b676038
ede2d62
6325040
f62a622
a5e6524
3d653fe
148ca05
70f578a
6c506e4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,4 +19,4 @@ jobs: | |
uses: actions/upload-artifact@v2 | ||
with: | ||
name: size_table | ||
path: size_table.html | ||
path: size_table.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ This repository contains the coreMQTT library that has been optimized for a low | |
|
||
This library has gone through code quality checks including verification that no function has a [GNU Complexity](https://www.gnu.org/software/complexity/manual/complexity.html) score over 8, and checks against deviations from mandatory rules in the [MISRA coding standard](https://www.misra.org.uk). Deviations from the MISRA C:2012 guidelines are documented under [MISRA Deviations](MISRA.md). This library has also undergone both static code analysis from [Coverity static analysis](https://scan.coverity.com/), and validation of memory safety through the [CBMC automated reasoning tool](https://www.cprover.org/cbmc/). | ||
|
||
See memory requirements for this library [here](https://docs.aws.amazon.com/embedded-csdk/202103.00/lib-ref/libraries/standard/coreMQTT/docs/doxygen/output/html/index.html#mqtt_memory_requirements). | ||
See memory requirements for this library [here](./docs/doxygen/include/size_table.md). | ||
|
||
**coreMQTT v1.1.0 [source code](https://github.com/FreeRTOS/coreMQTT/tree/v1.1.0/source) is part of the [FreeRTOS 202012.00 LTS](https://github.com/FreeRTOS/FreeRTOS-LTS/tree/202012.00-LTS) release.** | ||
|
||
|
@@ -122,6 +122,13 @@ Please refer to the demos of the MQTT client library in the following locations | |
|
||
## Generating documentation | ||
|
||
Note: For pre-generated documentation, please see the documentation linked in the above repositories: | ||
|
||
| Location | | ||
| :-: | | ||
| [AWS IoT Device SDK for Embedded C](https://github.com/aws/aws-iot-device-sdk-embedded-C#releases-and-documentation) | | ||
| [FreeRTOS.org](https://freertos.org/Documentation/api-ref/coreMQTT/docs/doxygen/output/html/index.html) | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If the released versions of C-SDK and FreeRTOS.org don't match, it would be confusing to customers about the reason of their disparity. It would be important to add a note saying that it is possible for the C-SDK and FreeRTOS releases to contain different release versions of coreMQTT There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added a note |
||
|
||
The Doxygen references were created using Doxygen version 1.8.20. To generate the | ||
Doxygen pages, please run the following command from the root of this repository: | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -129,6 +129,7 @@ mainpage | |
malloc | ||
managekeepalive | ||
matchtopic | ||
md | ||
mdash | ||
memcpy | ||
memset | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
name : "coreMQTT" | ||
version: "v1.1.1" | ||
version: "v1.1.2" | ||
description: | | ||
"Client implementation of the MQTT 3.1.1 specification for embedded devices.\n" | ||
license: "MIT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be better to have the table under a different section than "Generating Documentation" as Abhijit had mentioned that the main concern is that it makes it misleading for customers about them having to generate documentation.
If the table is present in a separate section, like "Existing Documentation", toward the beginning of the README, it would be easier for customers to notice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this?
Documentation
Existing Documentation
Generating Documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's fine. These can be moved before the Unit Tests section though to make it more prominent for customers to find