Add check for 0 packet ID for subacks #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muneebahmed10
force-pushed
the
malformed-suback
branch
from
856ecbd to
85b2c84
Compare
aggarw13
reviewed
Apr 19, 2021
| @@ -1164,8 +1164,15 @@ static MQTTStatus_t deserializeSuback( const MQTTPacketInfo_t * pSuback, | |||
| LogDebug( ( "Packet identifier %hu.", | |||
| ( unsigned short ) *pPacketIdentifier ) ); | |||
|
|
|||
| status = readSubackStatus( remainingLength - sizeof( uint16_t ), | |||
| pVariableHeader + sizeof( uint16_t ) ); | |||
| if( *pPacketIdentifier == 0U ) | |||
There was a problem hiding this comment.
Should the MQTT_PACKET_ID_INVALID macro be moved the serializer API?https://github.com/FreeRTOS/coreMQTT/blob/main/source/include/core_mqtt.h#L55-L61
Suggested change
| if( *pPacketIdentifier == 0U ) | |
| if( *pPacketIdentifier == MQTT_PACKET_ID_INVALID ) |
There was a problem hiding this comment.
Oh wow, I forgot about this. Possibly, but doing that is a larger change than what this PR was focused on.
muneebahmed10
force-pushed
the
malformed-suback
branch
from
85b2c84 to
6462a89
Compare
aggarw13
approved these changes
Jul 7, 2021
paulbartell
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
core_mqtt_serializer.cchecks for invalid packet IDs for all packets except for SUBACKs. Since packets are received from the network, we should check to make sure they are not malformed.This adds a zero packet ID check for subacks, adds an appropriate unit test, and updates the change log.
The license file had execute permissions for some reason. This removes them.