Set payload to NULL when zero length

FreeRTOS · Sep 18, 2020 · cd4d6a8 · cd4d6a8
1 parent c4990cb
commit cd4d6a8
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/source/core_mqtt_serializer.c b/source/core_mqtt_serializer.c
@@ -1274,6 +1274,9 @@ static MQTTStatus_t deserializePublish( const MQTTPacketInfo_t * pIncomingPacket
 
             LogDebug( ( "Packet identifier %hu.", *pPacketId ) );
 
+            /* Advance pointer two bytes to start of payload as in the QoS 0 case. */
+            pPacketIdentifierHigh += sizeof( uint16_t );
+
             /* Packet identifier cannot be 0. */
             if( *pPacketId == 0U )
             {
@@ -1286,17 +1289,17 @@ static MQTTStatus_t deserializePublish( const MQTTPacketInfo_t * pIncomingPacket
     {
         /* Calculate the length of the payload. QoS 1 or 2 PUBLISH packets contain
          * a packet identifier, but QoS 0 PUBLISH packets do not. */
-        if( pPublishInfo->qos == MQTTQoS0 )
-        {
-            pPublishInfo->payloadLength = ( pIncomingPacket->remainingLength - pPublishInfo->topicNameLength - sizeof( uint16_t ) );
-            pPublishInfo->pPayload = pPacketIdentifierHigh;
-        }
-        else
+        pPublishInfo->payloadLength = pIncomingPacket->remainingLength - pPublishInfo->topicNameLength - sizeof( uint16_t );
+
+        if( pPublishInfo->qos != MQTTQoS0 )
         {
-            pPublishInfo->payloadLength = ( pIncomingPacket->remainingLength - pPublishInfo->topicNameLength - 2U * sizeof( uint16_t ) );
-            pPublishInfo->pPayload = pPacketIdentifierHigh + sizeof( uint16_t );
+            /* Two more bytes for the packet identifier. */
+            pPublishInfo->payloadLength -= sizeof( uint16_t );
         }
 
+        /* Set payload if it exists. */
+        pPublishInfo->pPayload = ( pPublishInfo->payloadLength != 0 ) ? pPacketIdentifierHigh : NULL;
+
         LogDebug( ( "Payload length %lu.", ( unsigned long ) pPublishInfo->payloadLength ) );
     }